Skip to content

[Fix] Cloud save path input field can't be manually edited #3718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2024
Merged

[Fix] Cloud save path input field can't be manually edited #3718

merged 1 commit into from
Apr 27, 2024

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Apr 25, 2024

We have a bug in the logic, we are disabling the input when we are NOT syncing and we are enabling the field while we ARE syncing. This prevents fixing the path if it's wrong.

This PR fixes that by toggling the condition

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Apr 25, 2024
@arielj arielj requested review from a team, flavioislima, CommandMC, Etaash-mathamsetty, Nocccer and imLinguin and removed request for a team April 25, 2024 23:42
@arielj arielj mentioned this pull request Apr 26, 2024
Closed
@arielj arielj linked an issue Apr 26, 2024 that may be closed by this pull request
Can't manually set cloud save path in Win11 #3719
Closed
@arielj arielj merged commit c5c11e4 into main Apr 27, 2024
9 checks passed
@arielj arielj deleted the fix-disabled-save-path-input branch April 27, 2024 01:48
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Etaash-mathamsetty Etaash-mathamsetty Etaash-mathamsetty approved these changes

@flavioislima flavioislima Awaiting requested review from flavioislima flavioislima was automatically assigned from Heroic-Games-Launcher/development

@CommandMC CommandMC Awaiting requested review from CommandMC CommandMC was automatically assigned from Heroic-Games-Launcher/development

@Nocccer Nocccer Awaiting requested review from Nocccer Nocccer was automatically assigned from Heroic-Games-Launcher/development

@imLinguin imLinguin Awaiting requested review from imLinguin imLinguin was automatically assigned from Heroic-Games-Launcher/development

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't manually set cloud save path in Win11
2 participants
@arielj @Etaash-mathamsetty