Skip to content

Disable installing games with broken anticheat (add advanced setting for override) #3716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2024

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Apr 25, 2024

Users keep installing games like Fornite on linux even after all the warnings, so I'm making it harder to install without reading that the game will not work.

By default we now disable installing games with broken or denied anticheat. Users that care to read the messages will see that this measure can be disabled in the Advanced settings (I added even more warnings).

After checking the toggle in the advanced settings, the warning that asks users to click I understand this won't work, install anyway is still displayed.

I know this is more aggressive, but it's only more annoying for users that don't read. Advanced users can just disable this check once in the settings and it won't bother again.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Apr 25, 2024
@arielj arielj requested review from a team, flavioislima, CommandMC, Etaash-mathamsetty, Nocccer and imLinguin and removed request for a team April 25, 2024 02:19
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Another approach would be to disable the install button for like 10, 20 seconds and add a countdown inside it. But this one is fine as well 👍🏽

@arielj arielj merged commit 778670c into main May 17, 2024
9 checks passed
@arielj arielj deleted the disable-installing-games-with-broken-anticheat branch May 17, 2024 02:57
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants