Skip to content

[Revert] Refactor Extraction methods #3181 #3663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 9, 2024

Conversation

flavioislima
Copy link
Member

Revert this since its not being useful anymore and it is breaking arm64 builds.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima flavioislima dismissed imLinguin’s stale review August 7, 2024 16:44

concerns addressed

@flavioislima flavioislima added the pr:ready-for-review Feature-complete, ready for the grind! :P label Aug 7, 2024
@flavioislima flavioislima added this to the 2.15.0 milestone Aug 7, 2024
@flavioislima flavioislima requested a review from imLinguin August 7, 2024 16:45
Copy link
Collaborator

@CommandMC CommandMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My approval of course means less now, but still; LGTM

@flavioislima flavioislima merged commit 37ceada into main Aug 9, 2024
9 checks passed
@flavioislima flavioislima deleted the revert/extract_packages branch August 9, 2024 15:36
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants