Skip to content

[WORKAROUND]: run physxlegacy setup without user input #3616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

imLinguin
Copy link
Member

As we noticed in Heroic-Games-Launcher/known-fixes#7
the PHYSXLEGACY setup doesn't have a silent switch, or at least it doesn't respect it.

I came up with this simple solution, it should make the experience more hands free.

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@imLinguin imLinguin added the pr:ready-for-review Feature-complete, ready for the grind! :P label Mar 5, 2024
@imLinguin imLinguin requested review from a team, arielj, flavioislima, CommandMC, Etaash-mathamsetty and Nocccer and removed request for a team March 5, 2024 15:02
Copy link
Collaborator

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. Tested with Empire Earth 3 with and without this change.

With this change physx legacy is installed silently.

@imLinguin imLinguin added pr:ready-to-merge This PR is fully ready for merge. and removed pr:ready-for-review Feature-complete, ready for the grind! :P labels Mar 5, 2024
@flavioislima flavioislima changed the title [HACK]: run physxlegacy setup without user input [CHORE]: run physxlegacy setup without user input Mar 6, 2024
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Not sure if this could be called a hack, you are just adapting the command to what the dependency needs.

If was the case that we would need to handle several more dependencies with different commands then we could use a mapping object for it.

For me this is just a normal fix and I would remove the Hack commend before merging.
But I will leave it up to you 👍🏽

@imLinguin
Copy link
Member Author

Maybe a workaround is better suited for this

@imLinguin imLinguin changed the title [CHORE]: run physxlegacy setup without user input [WORKAROUND]: run physxlegacy setup without user input Mar 6, 2024
@flavioislima
Copy link
Member

Maybe a workaround is better suited for this

if you think about it, the whole Heroic is a 'workaround' or 'hack' to play the games without the official launchers 😂

@imLinguin
Copy link
Member Author

Maybe... but here we are branching out from the standard way even more 😄

@imLinguin imLinguin merged commit fe2444e into main Mar 6, 2024
@imLinguin imLinguin deleted the improv/handsfree-physx branch March 6, 2024 12:51
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-to-merge This PR is fully ready for merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants