Skip to content

Fix update dialog #3583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Mariaboni
Copy link
Contributor

@Mariaboni Mariaboni commented Feb 20, 2024

Hello!! I updated the update dialog according to what we discussed on this issue last week: #3534
image

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima
Copy link
Member

flavioislima commented Feb 20, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@Mariaboni
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@flavioislima flavioislima added the pr:ready-for-review Feature-complete, ready for the grind! :P label Feb 20, 2024
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for this contribution! :)

@arielj
Copy link
Collaborator

arielj commented Feb 20, 2024

One thing that could improve the UX is to re-open the same dialog if the user clicked the Changelog button.

Because I imagine this scenario:

  • you see the dialog
  • click Changelog
  • dialog closes and Changelog is displayed
  • you have no way to trigger the update cause the dialog is gone

if we extract the whole function we can do something like:

autoUpdater.on('update-available', showAutoupdateDialog)

and then that function can call itself when the dialog is closed with the Changelog button

  if (response === 2) {
    shell.openExternal(
      'https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/releases'
    )
    showAutoupdateDialog()
  }

the dialog will be closed but will open again automatically I'm guessing

@Mariaboni Mariaboni mentioned this pull request Feb 26, 2024
4 tasks
@flavioislima
Copy link
Member

Closing this one in favor of #3598 that includes your comments @arielj

@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants