[Fix] Sideloaded games on Windows #3562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case the array is empty, we have to make sure to not pass the parameter at all (otherwise PS will error out) This is used by sideloaded games
Sideloaded games pass their executable path as the runner. Before, this was done
a little incorrectly. Assume the selected executable is
`C:\Windows\System32\cmd.exe`. Before, the runner would then be:
{
bin: `C:\Windows\System32\cmd.exe`
dir: `C:\Windows\System32\`
}
callRunner then just `join`s together these paths, resulting in
`C:\Windows\System32\C:\Windows\System32\cmd.exe`. This is obviously wrong and
will not work.
Now, we correctly pass just the bin for `bin` (`cmd.exe` in our example). This
is also in-line with how regular runners work
CommandMC
added
the
pr:ready-for-review
CommandMC
requested review from
arielj,
flavioislima,
Etaash-mathamsetty,
Nocccer and
imLinguin
and removed request for
a team
CommandMC
added
pr:testing
This was somewhat flawed before; callRunner relied on an implementation detail of `splitPathAndName` (it adding "./" to the "bin"). The relevant code was now moved to callRunner itself
CommandMC
added
pr:ready-for-review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With my changes to callRunner (to use PowerShell on Windows), sideloaded games actually broke on Windows (for two different reasons!)
This fixes both of those problems (details as always in commit messages)
To test:
Well, try to run sideloaded games on Windows. Won't work on 2.13.0, will work with this PR.
Use the following Checklist if you have changed something on the Backend or Frontend: