[UX] Update order in library when an install starts #3523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielj
requested review from
a team,
flavioislima,
CommandMC,
Etaash-mathamsetty,
Nocccer and
imLinguin
and removed request for
a team
arielj
commented
Feb 5, 2024
| .filter((st) => st.status === 'installing') | ||
| .map((st) => st.appName), | ||
| [libraryStatus] | ||
| ) |
There was a problem hiding this comment.
replaced useState with useMemo to make it simpler
also removed the type since it's already inferred anyway, removes one import
flavioislima
approved these changes
Feb 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2001
We have code to sort games by: installed > installing > not installed, but when an installation starts it's currently not being sorted unless a re-render is triggered.
This PR fixes that.
To test this you can start installing a game and the card doesn't move to the top, then change to another screen, go back to the library and it's now sorted.
Use the following Checklist if you have changed something on the Backend or Frontend: