Skip to content

[UI] Fix extra scroll when UpdateComponent is displayed in the library #3407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2024
Merged

[UI] Fix extra scroll when UpdateComponent is displayed in the library #3407

merged 1 commit into from
Jan 7, 2024

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Jan 7, 2024

This PR fixes #3403

The content was not using the space correctly when the UpdateComponent was displayed while a top section was visible.

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jan 7, 2024
@arielj arielj requested a review from flavioislima January 7, 2024 01:38
flavioislima
flavioislima approved these changes Jan 7, 2024
View reviewed changes
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested here and works fine now. Thanks

@flavioislima flavioislima merged commit c98851d into main Jan 7, 2024
@flavioislima flavioislima deleted the fix-scroll-glitch-while-updating branch January 7, 2024 13:22
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Jan 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@flavioislima flavioislima flavioislima approved these changes

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
2 participants
@arielj @flavioislima