Install legendary prerequisites

[Etaash-mathamsetty]

Installs the prerequisites that legendary gives in the json when installing a game, we can rip out the dedicated ubisoft stuff with this change.

Use the following Checklist if you have changed something on the Backend or Frontend:

• Tested the feature and it's working on a current and clean install.
• Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
• Created / Updated Tests (If necessary)
• Created / Updated documentation (If necessary)

[Etaash-mathamsetty]

the only issue is to move all the setup functions so that they only happen post install or on first run, otherwise the setup functions will constantly run each launch. The way they currently work makes it extremely easy to test, so I will leave it like this for now.

[arielj]

Looks good! I tested with a few games with and without prerequisites (including ubisoft) and all works fine

I just left some comments and one question

[arielj]

Testing with RollerCoaster Tycoon 3 I get this error:

maybe we need to skip the args for the command when it's an empty string?

			"prerequisites": {
				"ids": [
					"DirectXJun2010Redist"
				],
				"name": "DirectX June 2010 Redistributable",
				"path": "directx_Jun2010_redist/DXSETUP.exe",
				"args": ""
			},

[Etaash-mathamsetty]

Testing with RollerCoaster Tycoon 3 I get this error:

maybe we need to skip the args for the command when it's an empty string?

			"prerequisites": {
				"ids": [
					"DirectXJun2010Redist"
				],
				"name": "DirectX June 2010 Redistributable",
				"path": "directx_Jun2010_redist/DXSETUP.exe",
				"args": ""
			},

i think the shlex.split should fix this, could you retest?

[arielj]

i think the shlex.split should fix this, could you retest?

yep! the shlex.split fixes that for rollercoaster tycoon

[arielj]

Looks good to me!

I only tested on linux, I understand this has no impact on windows.

Also, the only game that really needed the pre-requisites for me was XCOM 2 and that now works out of the box with this change.

For the other games I own it looks like the pre-requisites are not really needed for the games to work (I didn't need the pre-requisites for any other game), but I think it's good to install them anyway, doesn't seem to create any issue anyway.

[flavioislima]

left a small comment, looks good otherwise.