[Fix] DXVK-NVAPI installation #3347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Variables were renamed to (hopefully) be clearer, Promises are awaited instead of chaining them together with ".then", and the "echoCommand" and "cleanCommand" were replaced with Node functions
Before, we told tar to extract into the tool's directory (not into the final destination folder), and thus relied on the archive containing a sub-directory with the name we were looking for. DXVK-NVAPI doesn't do this, so we overwrote this behavior for it only. Now, we create the destination folder and extract to it, and use the `strip` parameter for tools that ship inside a sub-directory to remove this directory. This makes sure that the destination directory always exists, which resolves issues installing DXVK-NVAPI.
CommandMC
added
pr:ready-to-merge
|
looks good to me as well I'll rebase and merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DXVK-NVAPI wasn't installable due to the archive extraction directory not being created. While solving this, I've made some changes to hopefully make the whole install/update function more readable
Use the following Checklist if you have changed something on the Backend or Frontend: