-
-
Notifications
You must be signed in to change notification settings - Fork 480
[FEAT] Show Genres and Release date on Game Page #3330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…uncher into feat/pcgw_improvements
something that maybe could be in a future release would be to parse the date and then use internationalization, because now it's displayed as is in english |
Instead of printing the month as February I think we should use the number instead, then no translations are needed |
even if showing just number, we should still use localization, different languages have different conventions to show dates with just numbers (some countries use DD/MM/YYYY, others YYYY-MM-DD, others MM/DD/YYYY) The Intl module should handle all of that though, we don't need anything fancy. |
Yes, using Intl would be nice but we need to check if we can convert the current received string from PCGW to a real date. |
@arielj fixed all issues you pointed out. Thanks for testing it. |
…cher/HeroicGamesLauncher into feat/pcgw_improvements
Co-authored-by: Ariel Juodziukynas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
This PR updates PCGamingWiki request to get the Game's release date and the Genres.
For the Release date there is a small logic:
If on Linux and the game has a Native Linux release, it will show the Linux Release date.
Same for macOS.
If not available, it will show the Windows Release date.
OLD DESIGN
NEW DESIGN
Use the following Checklist if you have changed something on the Backend or Frontend: