Skip to content

[FEAT] Show Genres and Release date on Game Page #3330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Dec 27, 2023

Conversation

flavioislima
Copy link
Member

@flavioislima flavioislima commented Dec 18, 2023

This PR updates PCGamingWiki request to get the Game's release date and the Genres.

For the Release date there is a small logic:
If on Linux and the game has a Native Linux release, it will show the Linux Release date.
Same for macOS.
If not available, it will show the Windows Release date.

OLD DESIGN

image

NEW DESIGN

image


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima flavioislima self-assigned this Dec 18, 2023
@flavioislima flavioislima added the pr:ready-for-review Feature-complete, ready for the grind! :P label Dec 18, 2023
@arielj
Copy link
Collaborator

arielj commented Dec 19, 2023

there seems to be some edge cases when parsing the release dates:
image
image

@arielj
Copy link
Collaborator

arielj commented Dec 19, 2023

something that maybe could be in a future release would be to parse the date and then use internationalization, because now it's displayed as is in english

@Etaash-mathamsetty
Copy link
Member

Instead of printing the month as February I think we should use the number instead, then no translations are needed

@arielj
Copy link
Collaborator

arielj commented Dec 19, 2023

Instead of printing the month as February I think we should use the number instead, then no translations are needed

even if showing just number, we should still use localization, different languages have different conventions to show dates with just numbers (some countries use DD/MM/YYYY, others YYYY-MM-DD, others MM/DD/YYYY)

The Intl module should handle all of that though, we don't need anything fancy.

@flavioislima
Copy link
Member Author

Yes, using Intl would be nice but we need to check if we can convert the current received string from PCGW to a real date.

@flavioislima
Copy link
Member Author

@arielj fixed all issues you pointed out. Thanks for testing it.

@flavioislima flavioislima requested a review from arielj December 19, 2023 15:40
Copy link
Collaborator

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@flavioislima flavioislima merged commit 4b06f20 into main Dec 27, 2023
@flavioislima flavioislima deleted the feat/pcgw_improvements branch December 27, 2023 15:21
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Dec 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants