[UI/Fix] Set zoom limits along with zoom level instead of zoom factor #3325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielj
changed the title
arielj
changed the title
arielj
force-pushed
the
zoom-level-limit
branch
from
9b09ace to
78d97ce
Compare
arielj
added
pr:ready-for-review
arielj
requested review from
a team,
flavioislima,
CommandMC,
Etaash-mathamsetty,
Nocccer and
imLinguin
and removed request for
a team
arielj
commented
Dec 16, 2023
| } else { | ||
| return zoomFactor | ||
| return (zoomFactor - 1) / 0.2 |
There was a problem hiding this comment.
instead of setting a zoom factor (like 1.2, 1.4, 0.8, etc), setZoomLevel expects an integer with increments of 0.2 zoom
so a zoom of 80% is 0.8 zoom factor so it's -1 for zoom level
120% is 1.2 zoom factor so it's 1 zoom level
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #3324 and fixes #2156
Looks like in some cases, the zoom factor set with the accessibility settings was getting reset when the windows size changed.
I could not reproduce it during development but I was able to reproduce it using the Flatpak container (both on my linux desktop and on the steam deck). Set a zoom of 80%, move to another screen, and resize the window.
This PR uses the zoomLevel instead of zoomFactor and also sets the visual level limit to 1 and that seems to work correctly (tested both during development and with the generated flatpak).
Use the following Checklist if you have changed something on the Backend or Frontend: