[Feat] Support Epic's launch-able addons/DLCs #3317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also factors out the actual reading & parsing of the file into a new function (which will be required by the next commit)
This de-couples the shape of "launchArguments" from this option, which allows us to encode more detailed information in it (which will happen in the next commit)
The backend is now responsible for providing launch options. For GOG this required no changes, Amazon and sideloaded Games don't support launch options at all (so they just return an empty array). Legendary was a little more difficult: Other than the options listed in the game's metadata, launch options can also be added by the following: - If a DLC has an executable set, that DLC is also launch-able through Legendary - If a DLC has the "AdditionalCommandLine" attribute set, launching the game with the parameters specified is supposed to launch the DLC The latter is rather easy to implement, while the former requires re-thinking how we do launch arguments: "LaunchOption" is now an object with a type & type-specific properties. Its former shape is preserved in "BaseLaunchOption", which is still the only available option for anything non-Legendary. "DLCLaunchOption" is new, and holds the AppName of a DLC to launch instead of the main game. With this done, Legendary's "launch" function can simply replace the AppName passed to Legendary if a DLC launch option is passed to it.
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
Code looks good to me, but I have no way to test this. This is only for Fortnite, right? |
|
Yes |
CommandMC
added
pr:ready-for-review
|
could you update the legendary binaries to the latest release? |
|
Latest release's binaries don't alter this functionality (we'd have to use anything after |
flavioislima
approved these changes
Dec 18, 2023
CommandMC
force-pushed
the
feat/dlc-launch
branch
from
722e883 to
26629b1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for launch-able DLCs (for Epic/Legendary), used for the recent Fortnite "Experiences" and the Unreal Editor for Fortnite
I can't test this that well, as I don't have a Windows system with Fortnite installed, but it appears to be working. Further tests from people on our Discord might be coming soon
Use the following Checklist if you have changed something on the Backend or Frontend: