Skip to content

[UX] Add an 'only' action to select one store/platform only #3294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 10, 2023
Merged

[UX] Add an 'only' action to select one store/platform only #3294

merged 5 commits into from
Dec 10, 2023

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Dec 5, 2023 •
edited
Loading

This PR adds a button-thingy next to stores and platforms filters to select that single store/platform and de-select the rest, to bring back that behavior from the previous design.

filters-only.mp4

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Dec 5, 2023
@arielj arielj requested review from a team, flavioislima, CommandMC, Etaash-mathamsetty, Nocccer and imLinguin and removed request for a team December 5, 2023 22:09
@flavioislima
Copy link
Member

flavioislima commented Dec 5, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@arielj
Copy link
Collaborator Author

arielj commented Dec 5, 2023

I have read the CLA Document and I hereby sign the CLA

@arielj arielj changed the title Add an 'only' action to select one store/platform only [UX] Add an 'only' action to select one store/platform only Dec 8, 2023
flavioislima
flavioislima approved these changes Dec 10, 2023
View reviewed changes
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

@arielj arielj merged commit 612566c into main Dec 10, 2023
@arielj arielj deleted the filters-only branch December 10, 2023 17:45
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Dec 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@flavioislima flavioislima flavioislima approved these changes

@CommandMC CommandMC Awaiting requested review from CommandMC CommandMC was automatically assigned from Heroic-Games-Launcher/development

@Etaash-mathamsetty Etaash-mathamsetty Awaiting requested review from Etaash-mathamsetty Etaash-mathamsetty was automatically assigned from Heroic-Games-Launcher/development

@Nocccer Nocccer Awaiting requested review from Nocccer Nocccer was automatically assigned from Heroic-Games-Launcher/development

@imLinguin imLinguin Awaiting requested review from imLinguin imLinguin was automatically assigned from Heroic-Games-Launcher/development

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arielj @flavioislima