Skip to content

[Fix] Fix "Run Game Offline" not working on windows and mac #3106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Oct 3, 2023

In the prepareLaunch function we have an early return if not linux and it was only returning the discord presence flag but not the offline flag, so even with the setting the launch commands were not created with this argument. It only worked on Linux since it didn't do that early return.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Oct 3, 2023
@arielj arielj requested review from a team, flavioislima, CommandMC, Nocccer and imLinguin and removed request for a team October 3, 2023 02:29
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@Etaash-mathamsetty Etaash-mathamsetty merged commit 6f0cd49 into main Oct 18, 2023
@Etaash-mathamsetty Etaash-mathamsetty deleted the fix-offline-mode-on branch October 18, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants