-
-
Notifications
You must be signed in to change notification settings - Fork 480
[UI]: Divide GamePage component into multiple components #2848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tested here and everything seems to be working fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merged master because i couldn't retrigger workflow.
Can be merged if workflow this time succed.
I checked some game scroes and system compatibility. Everything still works except hltb but this is because they closed there open api endpoint.
…uncher into refactor-game-page
…/HeroicGamesLauncher into refactor-game-page
Merging this one to avoid future conflicts |
I started working in the redesign and I quickly found that the GamePage component was really complex and hard to work with because it kept growing and growing over time.
To be able to work more easily in the redesign, I'm extracting the different elements into individual components so we can move them around as needed without breaking functionality in the future.
Now the GamePage component fetches some info and passes that to the children, some by props and some by a context I added.
This is similar to what we have in the Settings screen.
Everything I tested worked fine, but would love to have more eyes on this since it affects the complete GamePage component.
Use the following Checklist if you have changed something on the Backend or Frontend: