Skip to content

[UI]: Divide GamePage component into multiple components #2848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 9, 2023

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Jul 8, 2023

I started working in the redesign and I quickly found that the GamePage component was really complex and hard to work with because it kept growing and growing over time.

To be able to work more easily in the redesign, I'm extracting the different elements into individual components so we can move them around as needed without breaking functionality in the future.

Now the GamePage component fetches some info and passes that to the children, some by props and some by a context I added.

This is similar to what we have in the Settings screen.

Everything I tested worked fine, but would love to have more eyes on this since it affects the complete GamePage component.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jul 8, 2023
@arielj arielj requested review from a team, flavioislima, CommandMC, Nocccer and imLinguin and removed request for a team July 8, 2023 21:21
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tested here and everything seems to be working fine.

@Nocccer Nocccer changed the title Divide GamePage component into multiple components [UI]: Divide GamePage component into multiple components Sep 4, 2023
@Nocccer Nocccer added this to the 2.9.2 milestone Sep 4, 2023
Copy link
Collaborator

@Nocccer Nocccer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged master because i couldn't retrigger workflow.
Can be merged if workflow this time succed.

I checked some game scroes and system compatibility. Everything still works except hltb but this is because they closed there open api endpoint.

@flavioislima
Copy link
Member

Merging this one to avoid future conflicts

@flavioislima flavioislima merged commit b958e87 into main Sep 9, 2023
@flavioislima flavioislima deleted the refactor-game-page branch September 9, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants