-
-
Notifications
You must be signed in to change notification settings - Fork 480
[Bug] Fix popover inside settings dialog #2822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,17 @@ | ||
.MuiPaper-root.MuiPopover-paper.popover-paper { | ||
background-color: var(--background); | ||
color: var(--text-primary); | ||
border: 1px solid var(--border-color); | ||
border-radius: 4px; | ||
box-shadow: 0 0 0 1px var(--border-color); | ||
padding: 16px; | ||
width: fit-content; | ||
max-width: 500px; | ||
overflow-y: auto; | ||
overflow-x: hidden; | ||
.popover-wrapper { | ||
position: relative; | ||
.popover { | ||
background-color: var(--background); | ||
color: var(--text-primary); | ||
border: 1px solid var(--border-color); | ||
border-radius: 4px; | ||
box-shadow: 0 0 0 1px var(--border-color); | ||
padding: 16px; | ||
width: fit-content; | ||
max-width: 500px; | ||
overflow-y: auto; | ||
overflow-x: hidden; | ||
position: absolute; | ||
z-index: 2; | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,4 @@ | ||
import Popover from '@mui/material/Popover/Popover' | ||
import React, { useState } from 'react' | ||
import React, { useEffect, useRef, useState } from 'react' | ||
import './index.scss' | ||
|
||
interface PopoverComponentProps { | ||
|
@@ -11,46 +10,45 @@ const PopoverComponent: React.FC<PopoverComponentProps> = ({ | |
item, | ||
children | ||
}) => { | ||
const [anchorEl, setAnchorEl] = useState<HTMLElement | null>(null) | ||
const open = Boolean(anchorEl) | ||
const [open, setOpen] = useState(false) | ||
const wrapper = useRef<HTMLDivElement>(null) | ||
|
||
const handleClick = (event: React.MouseEvent<HTMLElement>) => { | ||
// if already open, close it | ||
const handleClick = () => { | ||
setOpen(!open) | ||
} | ||
|
||
useEffect(() => { | ||
if (open) { | ||
setAnchorEl(null) | ||
return | ||
} | ||
// add a click listener to close the popover when clicking outside | ||
const callback = (event: MouseEvent) => { | ||
if (!wrapper.current!.contains(event.target as HTMLElement)) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if clicked outside the wrapper, close the popover |
||
setOpen(false) | ||
} | ||
} | ||
|
||
setAnchorEl(event.currentTarget) | ||
} | ||
document.addEventListener('click', callback) | ||
|
||
const handleClose = () => { | ||
setAnchorEl(null) | ||
} | ||
return () => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. when the popover is closed, remove the listener |
||
// remove the listener when the popover is closed | ||
document.removeEventListener('click', callback) | ||
} | ||
} else { | ||
return () => '' | ||
} | ||
}, [open]) | ||
|
||
return ( | ||
<> | ||
<div className="popover-wrapper" ref={wrapper}> | ||
{React.cloneElement(item, { | ||
onClick: handleClick, | ||
style: { cursor: 'pointer' } | ||
})} | ||
<Popover | ||
id={item.props.id} | ||
open={open} | ||
anchorEl={anchorEl} | ||
onClick={handleClick} | ||
onClose={handleClose} | ||
anchorOrigin={{ | ||
vertical: 'bottom', | ||
horizontal: 'left' | ||
}} | ||
classes={{ | ||
paper: 'popover-paper' | ||
}} | ||
> | ||
{children} | ||
</Popover> | ||
</> | ||
{open && ( | ||
<div id={item.props.id} className="popover"> | ||
{children} | ||
</div> | ||
)} | ||
</div> | ||
) | ||
} | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is only adding these last 2 props and the relative for the parent