Skip to content

[FIX] Switch to sniper runtime #2792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 24, 2023

Conversation

Etaash-mathamsetty
Copy link
Member

People who recently installed steam on Linux will have only the sniper runtime installed, therefore we should switch to it by default.

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@redromnon
Copy link
Collaborator

Maybe another alternative is to detect if the sniper runtime is installed first and then switch to that?

For instance, my system still has the older scout runtime since I didn't use Steam for quite some time. So launching a Linux native game from Heroic will fail to launch if I enable the checkbox unless I download the runtime from Steam. But I'm pretty sure many other users may not have the same case as me.

Another way is to display a dialog asking the user to install sniper runtime in Steam.

@Etaash-mathamsetty
Copy link
Member Author

Maybe another alternative is to detect if the sniper runtime is installed first and then switch to that?

For instance, my system still has the older scout runtime since I didn't use Steam for quite some time. So launching a Linux native game from Heroic will fail to launch if I enable the checkbox unless I download the runtime from Steam. But I'm pretty sure many other users may not have the same case as me.

Another way is to display a dialog asking the user to install sniper runtime in Steam.

Ok seems fair

@flavioislima
Copy link
Member

The Sniper runtime only works with version 8?
Perhaps we should have a method to get all available runtimes like we do for the Wine versions.

Then, depending on the Proton version we select the correct runtime. If it does not exists, simply ignore the runtime setting.

@Etaash-mathamsetty
Copy link
Member Author

Etaash-mathamsetty commented Jul 22, 2023

The Sniper runtime only works with version 8? Perhaps we should have a method to get all available runtimes like we do for the Wine versions.

Then, depending on the Proton version we select the correct runtime. If it does not exists, simply ignore the runtime setting.

that's going to be very hard how are we supposed to detect if a certain version of proton is proton 8? And some proton-tkg builds use soldier even on the 8.x series (I think)
I think we should just keep it simple and fall back to soldier when sniper is not found, proton isn't recommended anyway

@imLinguin
Copy link
Member

Doesn't tool manifest indicate that?

Copy link
Member

@imLinguin imLinguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one small syntax thing to consider

@imLinguin imLinguin added this to the 2.9 milestone Jul 24, 2023
@flavioislima flavioislima merged commit f83d036 into Heroic-Games-Launcher:main Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants