-
-
Notifications
You must be signed in to change notification settings - Fork 480
[FIX] Switch to sniper runtime #2792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Switch to sniper runtime #2792
Conversation
Maybe another alternative is to detect if the sniper runtime is installed first and then switch to that? For instance, my system still has the older scout runtime since I didn't use Steam for quite some time. So launching a Linux native game from Heroic will fail to launch if I enable the checkbox unless I download the runtime from Steam. But I'm pretty sure many other users may not have the same case as me. Another way is to display a dialog asking the user to install sniper runtime in Steam. |
Ok seems fair |
The Sniper runtime only works with version 8? Then, depending on the Proton version we select the correct runtime. If it does not exists, simply ignore the runtime setting. |
that's going to be very hard how are we supposed to detect if a certain version of proton is proton 8? And some proton-tkg builds use soldier even on the 8.x series (I think) |
Doesn't tool manifest indicate that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one small syntax thing to consider
Co-authored-by: Mathis Dröge <[email protected]>
Co-authored-by: Mathis Dröge <[email protected]>
Co-authored-by: Mathis Dröge <[email protected]>
Co-authored-by: Paweł Lidwin <[email protected]>
People who recently installed steam on Linux will have only the sniper runtime installed, therefore we should switch to it by default.
Use the following Checklist if you have changed something on the Backend or Frontend: