Skip to content

Prettier - Move exclamation mark to outside the single quotes of flatpak-build #2748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

ram1660
Copy link

@ram1660 ram1660 commented May 30, 2023

This is my first pull request.

In Windows when you try to run yarn prettier or yarn prettier-fix the commands won't work because the ! is being inside the single quotes of the "flatpak-build" and there maybe be difference between Windows and Linux where Windows treats the '!flatpak-build' as a folder while we are trying to ignore the folder.
By moving the exclamation mark to the outside of the single quote you will be able to run prettier and ignore the "flatpak-build" folder.
I have tested this in Windows and WSL Ubuntu and the and it works on both of them.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima flavioislima added pr:wip WIP, don't merge. pr:testing This PR is in testing, don't merge. labels May 31, 2023
@CommandMC CommandMC mentioned this pull request Nov 6, 2023
4 tasks
@arielj
Copy link
Collaborator

arielj commented Nov 25, 2023

closing as it was replaced by #3219

@arielj arielj closed this Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:testing This PR is in testing, don't merge. pr:wip WIP, don't merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants