Skip to content

[Feat] Use Legendary API to get SDL List (Fix Fortnite install and more) #2746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 31, 2023

Conversation

flavioislima
Copy link
Member

@flavioislima flavioislima commented May 30, 2023

For a long time Rodney from Legendary had this API that we could consult the list of Selective downloads, fixes, and more. But we were just hardcoding the list instead of getting from there and every time it changed we needed to update on our end as well.

This is fixed here, now, when opening the install modal for an Epic game we check on the API if there is any SDL available for it and list it right away. So if Rodney updates on the API it gets updated automatically on Heroic as well.

image image

Other Small fixes:

  • Fix the Install dialog showing a Browser Icon and install platform
  • Fix error dialog showing for shared memory errors (since they are handled already)

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima flavioislima added the pr:ready-for-review Feature-complete, ready for the grind! :P label May 30, 2023
@derrod
Copy link

derrod commented May 30, 2023

As a note, https://heroic.legendary.gl/v1/version.json has a game_overrides.sdl_config.<app name> key that indicates whether or not an SDL file exists and what version it is. Legendary itself uses this for caching SDL files and to avoid unnecessary requests to see whether or not one exists. So you could, for example, fetch the version information once on startup and then use that to determine if an SDL file needs to be downloaded without doing a request every time.

@flavioislima
Copy link
Member Author

As a note, https://heroic.legendary.gl/v1/version.json has a game_overrides.sdl_config.<app name> key that indicates whether or not an SDL file exists and what version it is. Legendary itself uses this for caching SDL files and to avoid unnecessary requests to see whether or not one exists. So you could, for example, fetch the version information once on startup and then use that to determine if an SDL file needs to be downloaded without doing a request every time.

Yes, I will add some caching to it.
We are just requesting it when the person clicks the install button. But I think I can cache it and setup a timer to expire.

@flavioislima flavioislima merged commit 6713384 into main May 31, 2023
@flavioislima flavioislima deleted the fix/sdl branch May 31, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants