Fix installation/update progress reports to the frontend #2683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielj
requested review from
a team,
flavioislima,
CommandMC,
Nocccer and
imLinguin
and removed request for
a team
arielj
commented
May 6, 2023
| // parse log for percent | ||
| const percentMatch = data.match(/Progress: (\d+\.\d+) /m) | ||
| if (!progress.percent) { |
There was a problem hiding this comment.
these checks were there in the original code, we need them to make sure we update only specific fields of the progress object
arielj
commented
May 6, 2023
| percent: undefined, | ||
| diskSpeed: undefined, | ||
| downSpeed: undefined | ||
| function defaultTmpProgress() { |
There was a problem hiding this comment.
these default object was inlined before and extracted here, but it needs to be inside a function so we always return a new object
the current code without a function passes the same object around and it's getting updated, it doesn't stay i this initial state
flavioislima
approved these changes
May 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression in 2.7.1 where the installation progress is not reported properly to the frontend.
Fixes #2680
Use the following Checklist if you have changed something on the Backend or Frontend: