Skip to content

Fix missing game settings info in logs #2638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Apr 18, 2023

This PR https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/pull/2563/files introduced a regression. Because we are calling writeFileSync in the 2 places, the second call (system info) replaces the content of the file that had the content of the first call (the game settings).

Now it uses writeFileSync for the game settings and then appendFileSync for the system info to not override the content.

The game settings are now the first part of the file, before the 2.7 release the system info was first. This is not that easy to avoid since the system info fetch is async on purpose cause it can get stuck, so we can't wait for it to be the beginning of the file.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj requested review from a team, flavioislima, CommandMC, Nocccer and imLinguin and removed request for a team April 18, 2023 03:10
@arielj arielj changed the title Fix missing game config info in logs Fix missing game settings info in logs Apr 18, 2023
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flavioislima flavioislima merged commit 6e6cc92 into main Apr 18, 2023
@flavioislima flavioislima deleted the fix-missing-log-info branch April 18, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants