Skip to content

[Enhancement] Add logic to Stores feature #2622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2023
Merged

[Enhancement] Add logic to Stores feature #2622

merged 1 commit into from
Apr 24, 2023

Conversation

redromnon
Copy link
Collaborator

This PR makes the store feature by adding a simple logic:

  • Open epic store by default
  • Open gog store only if gog account logged in

Solves #2620

Tested with both epic and gog logged in, only epic logged in and only gog logged in.

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@redromnon
Add logic to how store opens
36ab5c2 
- By default, the store will open epic store
- If only gog account logged in, store will open gog store
@redromnon redromnon linked an issue Apr 12, 2023 that may be closed by this pull request
If only logged into gog, default the store button to the gog store. #2620
Closed
@redromnon redromnon changed the title Add logic to how store opens [Enhancement] Add logic to Stores feature Apr 12, 2023
@redromnon redromnon requested a review from flavioislima April 12, 2023 16:54
@redromnon redromnon added the pr:ready-for-review Feature-complete, ready for the grind! :P label Apr 12, 2023
arielj
arielj approved these changes Apr 18, 2023
View reviewed changes
Copy link
Collaborator

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@flavioislima flavioislima merged commit a371082 into Heroic-Games-Launcher:main Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielj arielj arielj approved these changes

@flavioislima flavioislima Awaiting requested review from flavioislima

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

If only logged into gog, default the store button to the gog store.
3 participants
@redromnon @arielj @flavioislima