Skip to content

[UI] title on ETA #2518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 16, 2023
Merged

[UI] title on ETA #2518

merged 3 commits into from
Mar 16, 2023

Conversation

TornadoRadon
Copy link
Contributor

Just added a title on the estimated time on the downloading page. Without a title, it's hard to understand what this time means.

  • Tested the feature and it's working on a current and clean install.

@redromnon redromnon requested review from a team, arielj, flavioislima, CommandMC, Nocccer, imLinguin and redromnon and removed request for a team March 10, 2023 11:36
@Nocccer Nocccer added the pr:ready-for-review Feature-complete, ready for the grind! :P label Mar 11, 2023
@Nocccer
Copy link
Collaborator

Nocccer commented Mar 11, 2023

Can you add a image please how it looks.

arielj
arielj approved these changes Mar 16, 2023
View reviewed changes
Copy link
Collaborator

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, my only concern is that it's not accessible with a controller, but we have that problem in many places where we use the title attribute and we have to figure out a standard, I think that can be done in the future

@arielj arielj merged commit 2299a60 into Heroic-Games-Launcher:main Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielj arielj arielj approved these changes

@flavioislima flavioislima Awaiting requested review from flavioislima flavioislima was automatically assigned from Heroic-Games-Launcher/development

@CommandMC CommandMC Awaiting requested review from CommandMC CommandMC was automatically assigned from Heroic-Games-Launcher/development

@Nocccer Nocccer Awaiting requested review from Nocccer Nocccer was automatically assigned from Heroic-Games-Launcher/development

@imLinguin imLinguin Awaiting requested review from imLinguin imLinguin was automatically assigned from Heroic-Games-Launcher/development

@redromnon redromnon Awaiting requested review from redromnon redromnon was automatically assigned from Heroic-Games-Launcher/development

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TornadoRadon @Nocccer @arielj