Skip to content

[Enhancement]: Provide Wine-ge/Proton-ge latest version via wine manager #2513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 24, 2023

Conversation

Nocccer
Copy link
Collaborator

@Nocccer Nocccer commented Mar 3, 2023

This PR adds a Wine-GE and Proton-GE latest version which is updateable via the wine-manager.
The PR also cleans up some test and fixes some small issues.

  • Fixed issue where a error was thrown if one fetch call of one github repository failed. Now it shows a error, so other fetches can still succeed.
  • Replaced console.warn with logWarning

image
image
image
image
image


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@Nocccer Nocccer requested review from a team, arielj, flavioislima, CommandMC, imLinguin and redromnon and removed request for a team March 3, 2023 17:55
@Nocccer Nocccer added the pr:ready-for-review Feature-complete, ready for the grind! :P label Mar 3, 2023
@Etaash-mathamsetty
Copy link
Member

Etaash-mathamsetty commented Mar 3, 2023

I made a feature request for this in protonup-qt, and wanted to add it here too, but I guess you beat me to it lol thanks
will test later

@Etaash-mathamsetty
Copy link
Member

seems to be working

@Nocccer Nocccer requested a review from CommandMC March 11, 2023 17:35
@CommandMC
Copy link
Collaborator

Something more general: Currently, when a user is using this Wine version, there's no indication in the logs which exact version they're using (what I mean is: You just see "Wine-GE-Proton-Latest", while what "Latest" means depends on when the user last installed/updated it). Maybe something could be added in that regard (one approach would be adding an optional version property to WineInstallation & setting that to the tag name of the release)

@Nocccer
Copy link
Collaborator Author

Nocccer commented Mar 18, 2023

Something more general: Currently, when a user is using this Wine version, there's no indication in the logs which exact version they're using (what I mean is: You just see "Wine-GE-Proton-Latest", while what "Latest" means depends on when the user last installed/updated it). Maybe something could be added in that regard (one approach would be adding an optional version property to WineInstallation & setting that to the tag name of the release)

The property version is actually the name. I got the version tag into the name without big changes. Problem is that if there is a update, the version is already the new version even before you updaed it. Other ways seems to not be solved easy. We could introduce bugs in the logic of wine manager. Maybe we can refactor that in another pr ?

Example the installed Wine-GE-latest is actually 7-39 and after the update it should be 7-39-diablo
image

Also thinking of filter out specific builds by checking if they have a letter init.

@Nocccer
Copy link
Collaborator Author

Nocccer commented Mar 18, 2023

@CommandMC we need to fix the the information about the version in another pr. Everything i try breaks stuff. We should refactor the wine-manager anyway to a tool manager and downlaod dxvk and vkd3d over them aswell.

I just updated the name to ${type}-latest and sorted out specific wine-ge/proton-ge builds.

The latest entry points always to the latest none specific version in the list.

@Etaash-mathamsetty
Copy link
Member

Etaash-mathamsetty commented Apr 6, 2023

Seems to work well for me, I think once this is merged, we can make a PR that automatically installs wine if wine is not found

@flavioislima
Copy link
Member

Seems to work well for me, I think once this is merged, we can make a PR that automatically installs wine if wine is not found

Yes, good point. This is planned and we should prioritise that.

Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Nocccer Nocccer merged commit c94ea9c into main Apr 24, 2023
@Nocccer Nocccer deleted the enhancement/wine-latest branch April 24, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
4 participants