-
-
Notifications
You must be signed in to change notification settings - Fork 480
[Enhancement]: Provide Wine-ge/Proton-ge latest version via wine manager #2513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I made a feature request for this in protonup-qt, and wanted to add it here too, but I guess you beat me to it lol thanks |
seems to be working |
Something more general: Currently, when a user is using this Wine version, there's no indication in the logs which exact version they're using (what I mean is: You just see "Wine-GE-Proton-Latest", while what "Latest" means depends on when the user last installed/updated it). Maybe something could be added in that regard (one approach would be adding an optional |
@CommandMC we need to fix the the information about the version in another pr. Everything i try breaks stuff. We should refactor the wine-manager anyway to a tool manager and downlaod dxvk and vkd3d over them aswell. I just updated the name to The |
Seems to work well for me, I think once this is merged, we can make a PR that automatically installs wine if wine is not found |
Yes, good point. This is planned and we should prioritise that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
This PR adds a Wine-GE and Proton-GE latest version which is updateable via the wine-manager.
The PR also cleans up some test and fixes some small issues.
console.warn
withlogWarning
Use the following Checklist if you have changed something on the Backend or Frontend: