Skip to content

[UI] Display/allow user to copy alternate Epic login URL #2504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 18, 2023
Merged

[UI] Display/allow user to copy alternate Epic login URL #2504

merged 4 commits into from
Mar 18, 2023

Conversation

kshitijsubedi
Copy link
Contributor

@kshitijsubedi kshitijsubedi commented Feb 28, 2023 •
edited
Loading

Added Features:

  • Displays login URL
  • Button to Copy the URL to the clipboard
  • Button to Open Link in the Browser

Related Issue: #2245

Before:
image

After:
image

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@imLinguin imLinguin added the pr:ready-for-review Feature-complete, ready for the grind! :P label Mar 1, 2023
@flavioislima flavioislima requested review from a team, arielj, flavioislima, CommandMC, Nocccer, imLinguin and redromnon and removed request for a team March 1, 2023 11:01
imLinguin
imLinguin approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@imLinguin imLinguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Nocccer
Nocccer requested changes Mar 3, 2023
View reviewed changes
Copy link
Collaborator

@Nocccer Nocccer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to beside the button color.

@Nocccer Nocccer linked an issue Mar 3, 2023 that may be closed by this pull request
Visible url and/or copy to clipoard for the Alternative Login url #2245
Closed
@imLinguin imLinguin requested a review from Nocccer March 6, 2023 16:44
@Nocccer Nocccer changed the title [FEATURE] Display/allow user to copy alternate Epic login URL [Feature] Display/allow user to copy alternate Epic login URL Mar 18, 2023
@Nocccer Nocccer changed the title [Feature] Display/allow user to copy alternate Epic login URL [UI] Display/allow user to copy alternate Epic login URL Mar 18, 2023
Nocccer
Nocccer approved these changes Mar 18, 2023
View reviewed changes
Copy link
Collaborator

@Nocccer Nocccer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for contributing

@Nocccer Nocccer merged commit de92700 into Heroic-Games-Launcher:main Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nocccer Nocccer Nocccer approved these changes

@imLinguin imLinguin imLinguin approved these changes

@arielj arielj Awaiting requested review from arielj arielj was automatically assigned from Heroic-Games-Launcher/development

@flavioislima flavioislima Awaiting requested review from flavioislima flavioislima was automatically assigned from Heroic-Games-Launcher/development

@CommandMC CommandMC Awaiting requested review from CommandMC CommandMC was automatically assigned from Heroic-Games-Launcher/development

@redromnon redromnon Awaiting requested review from redromnon redromnon was automatically assigned from Heroic-Games-Launcher/development

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Visible url and/or copy to clipoard for the Alternative Login url
3 participants
@kshitijsubedi @Nocccer @imLinguin