Skip to content

[Tech] Resolve baseUrl in tests #2363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 19, 2023
Merged

[Tech] Resolve baseUrl in tests #2363

merged 2 commits into from
Jan 19, 2023

Conversation

CommandMC
Copy link
Collaborator

Originally part of #2176

Jest now knows about our baseUrl, making imports from backend/.../common/... possible. Nothing groundbreaking, just a nice-to-have when writing tests


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@CommandMC CommandMC added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jan 18, 2023
@CommandMC CommandMC requested a review from a team January 18, 2023 17:25
@CommandMC CommandMC self-assigned this Jan 18, 2023
@CommandMC CommandMC requested review from arielj, flavioislima, Nocccer, imLinguin and redromnon and removed request for a team January 18, 2023 17:25
Copy link
Collaborator

@Nocccer Nocccer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wonder if the test do not complain anymore for none test files. I had alot of situation where the test said it could not import backend/utils.ts in main.ts for example.

@CommandMC
Copy link
Collaborator Author

I wonder if the test do not complain anymore for none test files

Yup, that's also now resolved. Since you mentioned it, I've also gone over those files and removed some more redundant relative paths

@Nocccer
Copy link
Collaborator

Nocccer commented Jan 19, 2023

I wonder if the test do not complain anymore for none test files

Yup, that's also now resolved. Since you mentioned it, I've also gone over those files and removed some more redundant relative paths

Looked over it. I can't approve twice :D

@CommandMC CommandMC merged commit 6efc2ba into main Jan 19, 2023
@CommandMC CommandMC deleted the tech/jest-tsconfig-paths branch January 19, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants