Skip to content

[Fix] Save sync fixes #2350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jan 23, 2023
Merged

[Fix] Save sync fixes #2350

merged 15 commits into from
Jan 23, 2023

Conversation

flavioislima
Copy link
Member

@flavioislima flavioislima commented Jan 16, 2023

This moves the handling of the auto-save syncs to the backend. Instead of doing it in several different files on the frontend like we are doing today, it will just check the setting on the launch command and do the download and upload. This should fix an issue on steam deck gaming mode after closing the games, where the auto sync won't work since the frontend is killed after the launching.

It also should fix some cases where the save path input is not shown sometimes.
Also added a method to retry to get the saves path on click and cancel the searching for the save path.
Fixed the visual glitch (I can call that) when showing that it was searching for the saves path. Created a new component that shows a simple text with the progress and accepts a callback.
Removed the text that shows the save location for GOG games, I think that is too technical and have no use case for the end user unless for debugging. This was causing the layout to break and be different from the one on legendary saves.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima flavioislima marked this pull request as ready for review January 17, 2023 10:01
@flavioislima flavioislima added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jan 17, 2023
@flavioislima flavioislima added this to the 2.6.0 milestone Jan 17, 2023
Copy link
Collaborator

@Nocccer Nocccer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have some question if we catching sideload games.

@flavioislima flavioislima requested a review from Nocccer January 22, 2023 15:21
@flavioislima flavioislima merged commit cdcd16f into main Jan 23, 2023
@flavioislima flavioislima deleted the fix/sync_savs branch January 23, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants