-
-
Notifications
You must be signed in to change notification settings - Fork 499
[Fix] Save sync fixes #2350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[Fix] Save sync fixes #2350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uncher into fix/sync_savs
Nocccer
reviewed
Jan 19, 2023
Nocccer
reviewed
Jan 19, 2023
Nocccer
requested changes
Jan 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I have some question if we catching sideload games.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the handling of the auto-save syncs to the backend. Instead of doing it in several different files on the frontend like we are doing today, it will just check the setting on the launch command and do the download and upload. This should fix an issue on steam deck gaming mode after closing the games, where the auto sync won't work since the frontend is killed after the launching.
It also should fix some cases where the save path input is not shown sometimes.
Also added a method to retry to get the saves path on click and cancel the searching for the save path.
Fixed the visual glitch (I can call that) when showing that it was searching for the saves path. Created a new component that shows a simple text with the progress and accepts a callback.
Removed the text that shows the save location for GOG games, I think that is too technical and have no use case for the end user unless for debugging. This was causing the layout to break and be different from the one on legendary saves.
Use the following Checklist if you have changed something on the Backend or Frontend: