-
-
Notifications
You must be signed in to change notification settings - Fork 480
[macOS] Add support for app shortcuts #2161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and the shortcut has the right icon and shows up in the apps launcher properly, that's great.
I'm having an issue when I try to run a game using the shortcut, but I don't know if it's because I try running the app with yarn
Unable to find Electron app at /heroic:/launch/1207659026
Cannot find module '/heroic:/launch/1207659026'
Require stack:
- /Users/arielj/dev/oss/HeroicGamesLauncher/node_modules/electron/dist/Electron.app/Contents/Resources/default_app.asar/main.js
the content of the run.sh is:
/Users/arielj/dev/oss/HeroicGamesLauncher/node_modules/electron/dist/Electron.app/Contents/MacOS/Electron --no-gui heroic://launch/1207659026
if it helps
(I'm going to try installing the binary from this PR in a moment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using the installed app works fine, looks like it doesn't like the path when running as dev, but not a big deal
Implements #723
Adds shortcut inside HOME/Applications folder
The shortcut is a TITLE.app that contains a shell script to call Heroic with the
-no-gui
option.It also contains and icon for the game and a generic plist file that is needed for the app to run.
Used
nativeImage
from electron to resize the image and https://www.npmjs.com/package/@shockpkg/icon-encoder to convert it to .icns.Use the following Checklist if you have changed something on the Backend or Frontend: