[Logs] Add GOGdl and Legendary verbose log for any command output for better troubleshooting #2119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielj
requested review from
a team,
flavioislima,
CommandMC,
Nocccer,
imLinguin and
redromnon
and removed request for
a team
arielj
commented
Dec 1, 2022
src/backend/launcher.ts
Outdated
| @@ -737,6 +737,13 @@ async function callRunner( | |||
| rej('Process terminated with signal ' + signal) | |||
| } | |||
|
|
|||
| if (options?.runnerStdoutLog) { | |||
There was a problem hiding this comment.
stores verbose logs if an option is provided
arielj
commented
Dec 1, 2022
| .replace('.log', '') | ||
| .replaceAll('_', ':') | ||
| const logDate = new Date(dateString) | ||
| if ( | ||
| logDate.getFullYear() < date.getFullYear() || | ||
| logDate.getMonth() < date.getMonth() |
There was a problem hiding this comment.
this was deleting files if they were from last month instead of a month old
CommandMC
requested changes
Dec 2, 2022
|
thanks @CommandMC this is ready for another review |
CommandMC
approved these changes
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new log files to store all the output of Legendary and GOGdl.
The new files are stored next to heroic's general logs but the names are
legendary-....logandgogdl-.....loginstead ofheroic-....logand the same logic to delete old logs still applies to these new ones.There's no frontend view of these logs but they can be accessed using the same
Show log file in folderbutton for the general logs.I also fixed an issue where logs were being deleted when the month changed instead of when they were a month old (the 1st of each month it was we were deleting all files from last month).
Use the following Checklist if you have changed something on the Backend or Frontend: