Skip to content

[UI] Hide wine-related settings for games when Wine is not used #2008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 14, 2022

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Nov 7, 2022

This PR fixes a regresion after refactoring the settings that some wine settings where showing up for native games (native linux, window or mac).

With this PR, all the wine-related settings (wine, prefix, extensions, fps, fsr, fsync, esync, system libraries) are only shown in linux for non-native games.

Fixes #1998


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Nov 7, 2022
@arielj arielj requested review from a team, flavioislima, CommandMC, Nocccer, imLinguin and redromnon and removed request for a team November 7, 2022 23:09
Copy link
Collaborator

@redromnon redromnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Maybe one improvement would be to remove the specific native checks and only use one isNative

@flavioislima flavioislima merged commit e3c7350 into beta Nov 14, 2022
@flavioislima flavioislima deleted the fixes/hide-wine-settings branch November 14, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants