Skip to content

[UI] Hide Clear button for Library's Search Bar #2007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

redromnon
Copy link
Collaborator

@redromnon redromnon commented Nov 7, 2022

By default, the clear button (X) is always visible even if there's no input or text.

Instead, display the clear button whenever the user starts typing into the search bar and disable it when cleared.

clearsearchbutton.mp4

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

Show the clear button only when input or text is given for the library's game search bar
@redromnon redromnon added the pr:ready-for-review Feature-complete, ready for the grind! :P label Nov 7, 2022
@redromnon redromnon self-assigned this Nov 7, 2022
@redromnon redromnon requested review from a team, arielj, flavioislima, CommandMC, Nocccer and imLinguin and removed request for a team November 8, 2022 02:42
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@flavioislima flavioislima merged commit 087d00d into Heroic-Games-Launcher:beta Nov 8, 2022
@redromnon redromnon deleted the ui-hide-clearsearchbutton branch November 26, 2022 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants