Skip to content

[Legendary] Update linux binary #1991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2022
Merged

[Legendary] Update linux binary #1991

merged 1 commit into from
Nov 6, 2022

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Nov 5, 2022

This PR updates the linux binary for legendary to fix the issue with environment variables configuration in its config.ini.

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Nov 5, 2022
@arielj arielj requested review from a team, flavioislima, CommandMC, Nocccer, imLinguin and redromnon and removed request for a team November 5, 2022 00:39
@arielj arielj changed the title [Legendary] Update binary [Legendary] Update linux binary Nov 5, 2022
@flavioislima
Copy link
Member

Is this not affecting mac and Windows? Or the only replaced binary was the Linux one? Can you check that?

@arielj
Copy link
Collaborator Author

arielj commented Nov 5, 2022

Is this not affecting mac and Windows? Or the only replaced binary was the Linux one? Can you check that?

yes, it only affects the linux binary, checksum is correct for the win32 and darwin builds in current beta

flavioislima
flavioislima approved these changes Nov 6, 2022
View reviewed changes
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@arielj arielj merged commit c055021 into beta Nov 6, 2022
@arielj arielj deleted the legendary/update-binary branch November 6, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flavioislima flavioislima flavioislima approved these changes

@CommandMC CommandMC CommandMC approved these changes

@imLinguin imLinguin imLinguin approved these changes

@Nocccer Nocccer Awaiting requested review from Nocccer Nocccer was automatically assigned from Heroic-Games-Launcher/development

@redromnon redromnon Awaiting requested review from redromnon redromnon was automatically assigned from Heroic-Games-Launcher/development

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arielj @flavioislima @CommandMC @imLinguin