[General] Avoid unnecessary config writes #1988
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR checks settings values passed to
setSetting
and skips re-writing the config file if they haven't changed.In the process of this, I've applied a similar treatment our
useSetting
hook got togetSetting
andsetSetting
, which in turn involved setting a proper default value forcurrentConfig
. Since that can be eitherAppSettings
orGameSettings
, depending on whether we're editing the global or game-specific settings, I've also madeAppSettings
extendGameSettings
(so even if we only have aGameSettings
object under the hood, we can still interact with it like it's aPartial<AppSettings>
(since that's what it is))Use the following Checklist if you have changed something on the Backend or Frontend: