-
-
Notifications
You must be signed in to change notification settings - Fork 480
Gamepad navigation tweaks #1971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gamepad navigation tweaks #1971
Conversation
If you have the time, one good idea is to hide the buttons to play, install, etc on the card when a controller is detected, this will make the navigation smoother since right now it goes through the icons for every card. You can just hide the element and also would need to enable the settings option on the context menu and the play option as well. |
#e52644c does that, give it a try. So you are not a fan of disabling the buttons permanently but only when gamepad is being used? Personally, I would remove the icons for good and not just when a gamepad is being used. They make the library view too cluttered and this would result in a consistent and clean look. |
0b229c4
to
e52644c
Compare
Yes but clean look wont make it practical because then we would need to always open or the context menu (that some people dont know about it) or open the game page to access the settings and play the game, etc. Adding the buttons there actually was a request from several people when Heroic started because we didn't have them at first :) |
I am changing this to ready for review so we can grab the build files to test 👍🏽 |
Ok, the navigation without the buttons now looks good. |
Thanks for testing and feedback. Context menu options up next then. |
I would prefer not to lose the ability to open the game's setting or launch the game or trigger the install dialog with a single button. I think it's fine to make the A button always open the game page and to remove the buttons from the cards, but we could still keep actions in the gamepad buttons. With this change we don't have the buttons to fake the clicks, but we can still navigate to the settings page with javascript or launch the game sending a message to the backend for example. |
Not sure I understand what you mean. Something like launching/installing with button Y? |
e52644c
to
a964b9c
Compare
Currently, If you are using a controller you can select the card and use A to launch the game, or Y to open the game page. |
Yes, that was my intention. I think using the game page or the context menu to do anything with a game is fine. That's how it is done on the Steam Deck. Switching to heroic you find yourself launching games by pressing A you did not want to. |
Thats true. on the Deck using A makes the Game Page open. |
I would still keep something like Y to launch/install too, not instead. I think it's good to have all the options in the context menu but it's also nice to be able to access those options with less gamepad movements like it is now. I imagine a combination of:
|
Cool, looks like everyone can agree on play/install on Y in addition to the current PR. Going to add that and then the PR can use some more testing. |
Speaking about steam deck, what are your thoughts on using the menu (the 3 lines) button to show the context menu? currently it's X but the steam deck uses that one to show the options |
Did not notice the deck uses X but we should probably use the options button as well then. Just to not confuse users of both too much. |
to clarify, the deck does not use the X for the context, we do |
Got it. Something to keep in mind for the future if someone is at it. The reduced button usage in heroic works for now, other quality of life improvements like autofocus in library or navigation of store pages is more urgent I think. |
I'm not sure if navigating the stores with a controller is even possible |
a964b9c
to
c191d29
Compare
perhaps if we find a way of at least accepting the touch input like Steam does with external URLs on the deck. |
@wbrtm let us know once it is ready to review 👍🏽 |
hmmm not sure I understand the issue, I can use the stores with the touch screen, maybe it's an issue that happens only in gaming mode? I always use the heroic interface in desktop mode |
I use it in Gaming Mode most of the time and it is not possible to use the touch for that. |
Should open another issue for that. |
I'll try later, sure. Can you try one thing? when you hold down the STEAM button it should allow the right touch controls to move the mouse and act as a click, is that working? |
@arielj tried that already, tried everything to make it work. The only thing that works is clicking the scrollbar using the touchscreen or the Steam button + R2. |
@wbrtm testing it again here and one thing I noticed, not sure if it was introduced on this PR or on a previous one, is that after you get on a game page and then get back to library, the controller do not work anymore because heroic loses focus so you need to click on the window to activate the controller again. |
@flavioislima Yeah that was quite annoying while testing but I thought that was not introduced by my changes, didn't check though. Does that also occur on the deck? |
found the issue, was an |
public/locales/fr/gamepage.json
Outdated
@@ -33,7 +33,7 @@ | |||
}, | |||
"uninstall": { | |||
"checkbox": "Remove prefix: {{prefix}}{{newLine}}Note: This can't be undone and will also remove not backed up save files.", | |||
"message": "Voulez-vous désinstaller ce jeu ?", | |||
"message": "Voulez-vous désinstaller ce jeu\u202f?", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove these characters otherwise they will break the translations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do. I have no idea how this happened.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems resolved after rebase, please confirm.
c191d29
to
fec8032
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Weird, I just tried running heroic in gaming mode and I can navigate the stores just fine. Holding down the Steam button I can move around and click things in the store by either clicking the right touchpad or pressing R2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff!
Thanks for that 👍
Several tweaks regarding gamepad controls. The goal is app-wide consistency and better integration with steam deck controls.
Use the following Checklist if you have changed something on the Backend or Frontend: