[Tech] System info cache

[BrettCleary]

This improves game launch speed by caching system info that won't change while the app is running.

Time to launch was reduced from 20 seconds to 9 seconds with League of Legends on Windows.

It also speeds up Heroic launch time by ~5 seconds. Before, we were unnecessarily awaiting getSystemInfo before launching the main window. Now it runs asynchronously.

---

Use the following Checklist if you have changed something on the Backend or Frontend:

• Tested the feature and it's working on a current and clean install.
• Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
• Created / Updated Tests (If necessary)
• Created / Updated documentation (If necessary)

[CommandMC]

That 11 second metric seemed a bit high for me, so I've had a look into the systeminformation module we're using
Seems like they're executing PowerShell commands on Windows, which is why it's so slow.

Maybe we should someday implement this on our own, using Win32 API calls and/or WMI queries (there are npm modules for making both of those things easy, as far as I know). Those should be significantly faster

[BrettCleary]

That 11 second metric seemed a bit high for me, so I've had a look into the systeminformation module we're using Seems like they're executing PowerShell commands on Windows, which is why it's so slow.

Maybe we should someday implement this on our own, using Win32 API calls and/or WMI queries (there are npm modules for making both of those things easy, as far as I know). Those should be significantly faster

I was getting 5-10 seconds improvements consistently. Might be some user error in those numbers. Only tested on windows too

There's still no need for getSystemInfo to be synchronous and not cached. The only improvement we'd get by making the getSystemInfo call faster is if the app opens faster than getSystemInfo runs and the user launches a game before it finishes. In that case, we'd run getSystemInfo twice and the first game open would be slow. The app doesn't open that fast and I think most users won't launch a game in the first second the app opens.

It's also only used for logging so if this edge case becomes problem, we could disable system info logging on game launch since it's already logged on app start.

[CommandMC]

I was getting 5-10 seconds improvements consistently. Might be some user error in those numbers. Only tested on windows too

To clarify, I was not at all questioning your measurements, I was just observing & suspecting what the reason for a difference this significant might be

The app doesn't open that fast and I think most users won't launch a game in the first second the app opens.

This might happen when games are launched via the protocol

It's also only used for logging so if this edge case becomes problem, we could disable system info logging on game launch since it's already logged on app start.

This might be a bad idea, since users usually share just the game log & not the general one

[flavioislima]

Looks good 👍🏽