Skip to content

Fix setting not updating after another setting changes #1876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 11, 2022
Merged

Fix setting not updating after another setting changes #1876

merged 2 commits into from
Oct 11, 2022

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Oct 6, 2022

This PR fixes an issue after the settings refactor that the useSetting was not triggering a re-render other components after setting the new value.

It was using some useEffects/useStates but they were actually not needed.

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj requested a review from imLinguin October 6, 2022 23:50
@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Oct 7, 2022
flavioislima
flavioislima approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flavioislima flavioislima merged commit 341c8cb into beta Oct 11, 2022
@flavioislima flavioislima deleted the fix/settings-update-value branch October 11, 2022 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flavioislima flavioislima flavioislima approved these changes

@imLinguin imLinguin Awaiting requested review from imLinguin

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arielj @flavioislima