-
-
Notifications
You must be signed in to change notification settings - Fork 480
[Feature] Download Manager #1832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The pr doc is not up to date. I already added more frontend with MiB/s |
Also for the sidebar, the best thing to do (In my opinion) would be to only show the game that is currently installing, since showing the ones that are queued would be redundant and unnecessary to show in the sidebar. |
we are thinking on removing this and show the graphic instead or maybe dont show anything there and add some other way of seeing the current download. Perhaps using a floating snackbar that when clicked show the list or something like this. |
I don't think this was introduced on your branch, but I got this error message in the browser when clicking download initially
and on the backend:
So I have to log out and then back into my gog account. Then it works. Would be good to send a message to the frontend and prompt the user to re-login automatically for this case. |
I ran into an issue when following these steps:
The download didn't resume and I got the following error message from the backend
I was also able to click download again on the same the game and it queued it up again in the Download Manager. So there were two instances of the same undownloaded game in the download manager. I also couldn't cancel the current download. The native popup would show up but the app was unresponsive to any of the action buttons on that window. |
* css and layout changes * rounding disk and down values, layout improvements, colored disk and down labels
I agree that "Downloads" is better |
Also I think we should just use MB instead of MiB I agree with this Microsoft article |
this PR is functioning quite nicely from what I have tested so far, it's just that I would like to see updates showing up in the download manager as well, since they are not currently in there as far as I can tell. |
…uncher into feat/download-manager
…her/HeroicGamesLauncher into feat/download-manager
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested as much as I could.
Some thing that will need to be improved for next iteration:
Add support for updates
Add support for wine manager
Better UI
Use the following Checklist if you have changed something on the Backend or Frontend: