Skip to content

Try to use image cache for images with full url #1779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2022

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Sep 3, 2022

This PR changes the CachedImage component to not try to use the cache when the src of the img is relative.

Relative paths are local files so we don't really need to cache them and the cache handler fails to download that file since it's not a valid complete url. This avoid some errors in the backend for games with no image that has to use the fallback and makes the component easier to re-use without worring about the url passed as src.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Sep 3, 2022
@flavioislima flavioislima merged commit 70278ea into main Sep 10, 2022
@flavioislima flavioislima deleted the cached-images-improvement branch September 10, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants