Skip to content

[Fix] Some things missed in the EOS Overlay PR #1563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 16, 2022
Merged

[Fix] Some things missed in the EOS Overlay PR #1563

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a1a6a58
Create Wineprefix if it doesn't exist
CommandMC Jul 11, 2022
57ea6a9
Fastpath for Windows
CommandMC Jul 11, 2022
8057dbe
Only return latest version if overlay is installed
CommandMC Jul 11, 2022
b55c395
Off-load onClick functions to dedicated functions + multiple improvem…
CommandMC Jul 11, 2022
3bcc8bb
Frontend clean up
Nocccer Jul 11, 2022
2f327a8
lint fix
Nocccer Jul 11, 2022
ab5833f
Review fixes
Nocccer Jul 11, 2022
7b88bc7
Fix: Missing !
CommandMC Jul 11, 2022
88fd3fe
Improve isEnabled check a bit
CommandMC Jul 11, 2022
11c2e1c
Merge branch 'beta' into fix/eos-overlay-empty-prefix
CommandMC Jul 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions electron/legendary/eos_overlay/eos_overlay.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,10 @@ function getStatus(): {

async function getLatestVersion() {
if (!existsSync(currentVersionPath)) {
// HACK: `overlay_version.json` isn't created when the overlay isn't installed
if (!isInstalled()) {
return ''
}
await updateInfo()
if (!existsSync(currentVersionPath)) {
logError(
Expand All @@ -58,6 +62,11 @@ async function getLatestVersion() {
}

async function updateInfo() {
// Without the overlay being installed, this will do nothing at all.
// So we can just skip running the command if that's the case
if (isInstalled()) {
return
}
await runLegendaryCommand(['status'], {
logMessagePrefix: 'Updating EOS Overlay information'
})
Expand Down