Skip to content

Fix detection of search bar focus to open virtual keyboard #1450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Fix detection of search bar focus to open virtual keyboard #1450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/UI/SearchBar/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export default function SearchBar() {
ref={input}
data-testid="searchInput"
placeholder={t('search')}
id="search"
id="search" // this id is used for the virtualkeyboard, don't change it
className="FormControl__input"
/>
</FormControl>
Expand Down
2 changes: 1 addition & 1 deletion src/helpers/gamepad.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ export const initGamepad = () => {
const el = currentElement()
if (!el) return false

return el.classList.contains('searchInput')
return el.id === 'search'
}

function playable() {
Expand Down