[General] Fix: No longer replace token/sid with redacted #1442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sends a *copy* of commandParts to getRunnerCallWithoutCredentials, which should avoid it overwriting the sid/token passed to legendary/gogdl
CommandMC
requested review from
imLinguin and
Nocccer
and removed request for
imLinguin
Nocccer
approved these changes
Jun 7, 2022
Nocccer
changed the title
CommandMC
added
pr:ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like arrays are passed by reference in JS, which means the getRunnerCallWithoutCredentials function was altering the actual commandParts passed to Legendary/GOGDL. By copying the array before passing it, this no longer happens
Use the following Checklist if you have changed something on the Backend or Frontend: