-
-
Notifications
You must be signed in to change notification settings - Fork 480
[UI] Update login with new designs #1376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI] Update login with new designs #1376
Conversation
Thanks for the contribution! 👍🏽 |
Good point! I'll make some revisions so that it looks closer to the original design |
@tildemarky are you still gonna work on this one? I think you have a few conflicts and the design might need some adjustments but it is pretty close. Sorry for forgetting about this one as well. @biliesilva can you take a look at this latest screenshot and see what needs to be improved for the final design once you have the time? |
Hey sorry for the late reply @flavioislima, things got very hectic. I'll push an update with suggested changes within the coming week if nobody else has already stepped forward with this or a different concept. |
no worries. |
Still working on conflicts 😅 |
511f89b
to
5090b2e
Compare
The current look with the suggested changes! The language selector is mostly left as is, because the design changes would probably require changing the strings to not include the flag so it can be separately styled away from the language label, so that should maybe be its own PR. Not entirely sure. Let me know if anything else should be adjusted @flavioislima & @biliesilva |
@tildemarky can you use |
Do I also commit the translation files once they're picked up? I've never used i18next before so the procedure is a bit new to me and I'm not sure if I'm the one to do that or if it gets automatically picked up during a later build. |
Yes, commit the modified files. For more details check https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/wiki/Translations#how-to-add-new-translatable-strings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Added the new vertical design to the login screen without adding additional components, leaving spacing for additional stores to be added as their own Runners.
Open to making more design changes to more closely fit the design image posted in the reference issue #1153
Use the following Checklist if you have changed something on the Backend or Frontend: