Skip to content

[UX] Open main window on tray double click #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2022
Merged

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented May 16, 2022

This PR adds the feature of opening the main window when double clicking the icon in the Tray/Taskbar.

This DOES NOT work on linux, the events that we need to listen to only work on window and mac as stated in the Electron docs https://www.electronjs.org/docs/latest/api/tray/#event-double-click-macos-windows

There is no possible workaround for Linux until electron adds support for it.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label May 16, 2022
@arielj arielj linked an issue May 16, 2022 that may be closed by this pull request
@flavioislima flavioislima changed the title Open main window on try double click [UX] Open main window on tray double click May 16, 2022
@flavioislima
Copy link
Member

Looks good!

@flavioislima flavioislima added pr:ready-to-merge This PR is fully ready for merge. and removed pr:ready-for-review Feature-complete, ready for the grind! :P labels May 16, 2022
@arielj arielj merged commit 3cc4d08 into main May 19, 2022
@arielj arielj deleted the feature/tray-double-click branch May 19, 2022 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-to-merge This PR is fully ready for merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Double click tray icon doesn't bring up the window.
2 participants