Refactor: Form elements #1315
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,93 @@ | ||
| .selectWrapper { | ||
| display: grid; | ||
| grid-template-areas: 'label' 'select'; | ||
| } | ||
|
|
||
| .selectWrapper select { | ||
| grid-area: select; | ||
| width: 100%; | ||
| height: 40px; | ||
| background: var(--input-background); | ||
| border-radius: 10px; | ||
| font-family: var(--content-font-family), 'Noto Color Emoji'; | ||
| font-weight: normal; | ||
| font-size: 16px; | ||
| line-height: 19px; | ||
| color: var(--text-secondary); | ||
| text-indent: 22px; | ||
| border: none; | ||
| box-shadow: 0px 4px 4px rgba(0, 0, 0, 0.25); | ||
| cursor: pointer; | ||
| background-image: linear-gradient( | ||
| 45deg, | ||
| transparent 50%, | ||
| var(--text-secondary) 50% | ||
| ), | ||
| linear-gradient(135deg, var(--text-secondary) 50%, transparent 50%), | ||
| linear-gradient(to right, #ccc, #ccc); | ||
| background-position: calc(100% - 20px) calc(50% + 1px), | ||
| calc(100% - 15px) calc(50% + 1px), calc(100% - 40px) 50%; | ||
| background-size: 5px 5px, 5px 5px, 1px 70%; | ||
| background-repeat: no-repeat; | ||
| margin: 0; | ||
| -webkit-box-sizing: border-box; | ||
| -moz-box-sizing: border-box; | ||
| box-sizing: border-box; | ||
| -webkit-appearance: none; | ||
| -moz-appearance: none; | ||
| min-width: 100px; | ||
| } | ||
|
|
||
| .selectWrapper label { | ||
| justify-self: flex-start; | ||
| grid-area: label; | ||
| align-self: center; | ||
| } | ||
|
|
||
| .selectWrapper select:disabled { | ||
| cursor: not-allowed; | ||
| } | ||
|
|
||
| .selectWrapper.small select { | ||
| width: clamp(150px, 10rem, 372px); | ||
| } | ||
|
|
||
| .selectWrapper.smaller select { | ||
| width: 66px; | ||
| text-indent: 11px; | ||
| } | ||
|
|
||
| .selectWrapper.small, | ||
| .selectWrapper.smaller { | ||
| grid-template-areas: 'select label'; | ||
| grid-template-columns: min-content 1fr; | ||
| } | ||
|
|
||
| .selectWrapper.small label, | ||
| .selectWrapper.smaller label { | ||
| margin: 0px 1rem; | ||
| } | ||
|
|
||
| .selectWrapper select > option { | ||
| background: var(--navbar-background); | ||
| height: 40px; | ||
| color: var(--text-secondary); | ||
| text-indent: 22px; | ||
| font-size: 16px; | ||
| border-radius: 10px; | ||
| } | ||
|
|
||
| .selectWrapper.rightButtons { | ||
| grid-template: 'label label' 'select buttons'; | ||
| grid-template-columns: auto min-content; | ||
| grid-column-gap: 0.5rem; | ||
| } | ||
|
|
||
| .selectWrapper.rightButtons label { | ||
| grid-area: label; | ||
| } | ||
|
|
||
| .selectWrapper.rightButtons .rightButtons { | ||
| grid-area: buttons; | ||
| align-self: center; | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing, not really related with the PR.
Have you noticed that we are using two different folder icons? one on the settings and another on the InstallModal.
I think we should pick one, maybe the one that we are using on the InstallModal looks a bit better imo.
But we can do that in another task if you think this could increase the scope of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I didn't know the reason so I just skipped that, I agree that a single icon in all palces would look better
I'm also thinking about adding another component
PathInputFieldthat would take care of the input with the folder icon, we use that in a lot of places, I think it's a good opportunity to simplify thatThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I extracted a TextInputWithIconField component instead, maybe we can extract a PathInputField in the future, but not all path inputs behave the same so decided to go with a more generic input with icon