Skip to content

Add favourites feature and library top section config #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 1, 2022

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Apr 29, 2022

This PR uses a similar pattern used for the feature to hide games but to implement the feature of marking games as Favourites. As discussed in Discord, I also added a configuration in the General Settings to configure what is displayed at the top of the Library (nothing / recently played / favourites).

favourites.mp4

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Apr 29, 2022
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested here and everything works pretty good. ⚔️
Two things that I believe could be better:
On the settings, put the new setting above the Max Workers one
Put the Recently played as the default setting since it's the current behavior.

@arielj arielj requested a review from flavioislima May 1, 2022 14:38
@arielj
Copy link
Collaborator Author

arielj commented May 1, 2022

Tested here and everything works pretty good. crossed_swords Two things that I believe could be better: On the settings, put the new setting above the Max Workers one Put the Recently played as the default setting since it's the current behavior.

done, I moved the setting, changed the default and also added translatable strings for the options that I forgot that

@flavioislima flavioislima merged commit a71caa9 into main May 1, 2022
@flavioislima flavioislima deleted the feature/favourites branch May 1, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants