Skip to content

Fix keys in config file for recent games #1248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Apr 28, 2022

Closes #1000

The problem was the object set when there's nothing yet in the recent games, the else was setting the property game instead of appName. Check the linked issue for the content of the config with this bug.

I'm also filtering out recent games data with no appName property (to clean that from users with the problem).


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Apr 28, 2022
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@flavioislima flavioislima merged commit 08548f3 into main Apr 28, 2022
@flavioislima flavioislima deleted the fix/incorrect-first-recent-game branch April 28, 2022 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate games in system tray context menu
2 participants