Add option to hide games from the library #1228
Conversation
| (configStore.get('games.recent') as Array<RecentGame>) || [] | ||
| const recentGamesList = recentGames.map((a) => a.appName) as string[] | ||
|
|
||
| return library.filter((game) => recentGamesList.includes(game.app_name)) |
There was a problem hiding this comment.
While coding this feature initially I used a similar method like this one so I included this refactor. The refactor is a small improvement (we don't need to initialize the store and query it for every callback function call) but I can remove it from this PR if it adds noise, since it's not really needed for this feature at the end.
|
Personally, I don't like the idea of having more text on the header. something like this: Using: what do you think? with that approach, we can add a Star or Heart to show/hide favorites as well. |
I can change that to try, what I'm worried about is that an eye icon doesn't make it obvious that it will show/hide hidden games. I imagine a user clicking the icon to see what happens, if they didn't hide any game nothing will happen. I guess the tooltip would give a hint if the user leaves the mouse hovering the icon long enough, but tooltips don't show up when using the controller to navigate heroic. Maybe I'm overthinking it xD |
|
Yes. Let's collect some feedback on the beta. 😀 |
|
I moved this right next to the Total Games label, I imagine that would give more context that the icon is related to how many games you can see
I also fixed a bug, the selection of the filter was not persisted. |
| @@ -93,6 +93,10 @@ | |||
| border-bottom-right-radius: 0; | |||
| } | |||
|
|
|||
| .FormControl--segmented > button > svg { | |||
| display: block; | |||
| } | |||
There was a problem hiding this comment.
the svg icons where not properly centered (svg images are inline by default and it was adding a few empty pixels under it)
This PR adds a the ability to mark games from the library as
hiddenso they don't show up by default. This can be toggled on/off with the new checkbox.Games can be hid/unhid using the right click context menu.
You can see it working in this video with the game A Short Hike (second to last, bottom right)
hide-games.mp4
(The total games counter changes by more than 1 because I have other hidden games outside the viewport)
This I tried and was not happy with (but accept any feedback):
Show hiddentoggle instead of text, it didn't look clear at least to meHaven't tested with Unreal Market (I don't use it, I don't know if this is expected to work there too? I understand it works but I don't know if we should ignore this feature there).
Closes #948
Use the following Checklist if you have changed something on the Backend or Frontend: