Skip to content

Keep installing if the pause/stop dialog is closed #1196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 2, 2022

Conversation

Aikufurr
Copy link
Contributor

@Aikufurr Aikufurr commented Apr 9, 2022

Currently, the confirmation dialog for stopping a download will default to stopping the download and removing all files if the dialog is closed. Adding cancelId: 0 will instead default to resuming the download.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

Copy link
Collaborator

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this and it works as expected (closing the dialog with the ESC key works like clicking Keep Installing)

Also all buttons work as expected with this change too.

@flavioislima
Copy link
Member

@Aikufurr can you provide more info on how to replicate this?

@Aikufurr
Copy link
Contributor Author

@flavioislima So currently, if you start a download and then press the PAUSE/CANCEL button it brings up the dialog, if at that point you press ESC or close it via pressing the X the download is cancelled and doesn't save the files. With this commit, repeating those actions now continues the download instead of pausing/cancelling.

@flavioislima flavioislima merged commit 6df243a into Heroic-Games-Launcher:main May 2, 2022
@flavioislima
Copy link
Member

@Aikufurr thanks for fixing that 👍🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants