Skip to content

Open game store page in webview and refactor #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 26, 2022

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Mar 22, 2022

This PR fixes #863 by making the stores open in the webview instead of a popup.

I did a small refactor:

  • moved the epic url generation at the loading of the file so gameInfo.store_url works for both gog and epic
  • we can open the generic page with no language code and the epic store will use the user's language
  • I cleaned a little bit of the webview url handling for the login/:runner routes

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj requested a review from flavioislima March 23, 2022 22:57
@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Mar 23, 2022
@flavioislima
Copy link
Member

Looks good.
One thing I noticed though is that it doesn't highlight the right store when opening it.
So for epic games, the epic games submenu should be marked as active. Should be a simple fix I believe.

@arielj
Copy link
Collaborator Author

arielj commented Mar 25, 2022

@flavioislima this is ready for a second review, I added the highlight on the sidebar links when it applies

Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty good! Thanks for that! 👍🏽

@flavioislima flavioislima merged commit 0c8a5c1 into main Mar 26, 2022
@flavioislima flavioislima deleted the feature/open-store-page-in-webview branch March 26, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store Page button opens the link in a new window instead of the webview
2 participants